Skip to content

Conversation

katieklein
Copy link
Contributor

@katieklein katieklein commented Sep 5, 2024

Description of changes:

Long words like "AmplifyBackendDeployFullAccess" can get cut off on 320px viewport sizes.

example: https://docs.amplify.aws/react/start/account-setup
Screenshot 2024-06-14 at 3 10 27 PM

staging: https://a11y-long-words.d1egzztxsxq9xz.amplifyapp.com
page: /react/start/account-setup

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@katieklein katieklein requested a review from a team as a code owner September 5, 2024 19:13
Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I've never even seen overflow-wrap before lol

@katieklein katieklein merged commit f490314 into main Sep 17, 2024
12 checks passed
@katieklein katieklein deleted the a11y-long-words branch September 17, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants